Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester B] Pair command invalid index does not produce the correct error #146

Closed
nus-se-bot opened this issue Apr 5, 2024 · 1 comment · Fixed by #191
Closed

[PE-D][Tester B] Pair command invalid index does not produce the correct error #146

nus-se-bot opened this issue Apr 5, 2024 · 1 comment · Fixed by #191
Assignees
@sdevih
Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.VeryLow Bugs that are cosmetic and does not affect usage

Comments

@nus-se-bot
Copy link

Similar to Issue#1, the error describing an invalid command format is thrown when actually the error is an invalid index:

image.png

Fix by simply aligning with:

image.png

Labels: type.FunctionalityBug severity.Low
original: quelinxiao/ped#2
@chaaaaun
Copy link

chaaaaun commented Apr 8, 2024

Duplicates #171. Issue is likely due to how the Index class disallows 0, but positive indexes pass that test and fail a validity check later on. Might have to throw a custom error at the Parser stage.

@chaaaaun chaaaaun added the severity.VeryLow Bugs that are cosmetic and does not affect usage label Apr 8, 2024
@CJerrong CJerrong added the bug.Clarify Not sure, seek further clarification if we can edit. label Apr 9, 2024
@sdevih sdevih self-assigned this Apr 10, 2024
@gerteck gerteck added bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary and removed bug.Clarify Not sure, seek further clarification if we can edit. labels Apr 11, 2024
@gerteck gerteck mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdevih sdevih

Labels
bug.Deferred Not allowed under v1.4, mention in relevant documents (UG/DG) if necessary severity.VeryLow Bugs that are cosmetic and does not affect usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Bug Reports from PE-D gerteck/tp
5 participants
@nus-se-bot @CJerrong @chaaaaun @gerteck @sdevih