fix: change all methods in CsvUtil class to be static #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2324S2-CS2103T-T10-1/tp: (37 commits) fix: resolve merge conflicts and formatting of developer guide fix: delete incomplete AddScoreSequenceDigram fix: push merged changes to branch Reorganize DG manual testing reformat exams section fix: update implementation details of developer guide fix: remove unnecessary section from implementation details in developer guide docs: update implementation details of developer guide Docs: specify that activity diagram represents the workflow Style: update activity diagrams with ab3 styling Bug Fix: Find Command Parser Update Manual Testing Section in DG Update DG docs: update instructions for manual testing section of developer guide Docs: add planned implementation for validation for find command Docs: Add planned enhancements docs: add effort section in appendix of developer guide Test: refactor test Docs: Refine manual testing Docs: Add manual testing for 7 commands ...
* 'master' of https://github.com/AY2324S2-CS2103T-T10-1/tp: Fix Typo in DG Reformat titles Fix typos Format implementation section of DG Changes to sequence diagram Changes to sequence diagram Changes to sequence diagram Changes to sequence diagram Satisfy github CI actions Seperate sequence diagram into parsing and execution Changes to manual testing Line break for CsvUtil box in puml diagram Add manual testing for relevant exam commands Satisfy github CI action Update changes to import implementation to the developer guide
* master: (163 commits) Fix Typo in DG Reformat titles Fix typos Format implementation section of DG Changes to sequence diagram Changes to sequence diagram Changes to sequence diagram Changes to sequence diagram Satisfy github CI actions Seperate sequence diagram into parsing and execution fix: resolve merge conflicts and formatting of developer guide fix: delete incomplete AddScoreSequenceDigram fix: push merged changes to branch Changes to manual testing Reorganize DG manual testing reformat exams section fix: update implementation details of developer guide fix: remove unnecessary section from implementation details in developer guide docs: update implementation details of developer guide Docs: specify that activity diagram represents the workflow ...
the methods in CsvUtil should be static but all methods in this class should be static.
danielleloh
added
type.Task
danielleloh
requested review from
jayllo-c,
Zer0Legion,
delishad21 and
Pughal77
jayllo-c
reviewed
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the methods in CsvUtil should be static. Edit all methods in this class to be static.