Merge pull request #296 from Tsenrae/Branch-Json-Editing-Bugs

Fix bug with loading data when editing json file
AY2324S2-CS2103T-T11-1 · Apr 11, 2024 · 5069f70 · 5069f70
2 parents 36434a0 + ca110ad
commit 5069f70
Showing 1 changed file with 45 additions and 0 deletions.
diff --git a/src/main/java/seedu/address/storage/JsonSerializableAddressBook.java b/src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
@@ -3,7 +3,9 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
+import java.util.HashMap;
 import java.util.List;
+import java.util.UUID;
 import java.util.stream.Collectors;
 
 import com.fasterxml.jackson.annotation.JsonCreator;
@@ -17,6 +19,8 @@
 import seedu.address.model.person.Person;
 import seedu.address.model.person.relationship.Relationship;
 import seedu.address.model.person.relationship.RoleBasedRelationship;
+import seedu.address.model.person.relationship.SiblingRelationship;
+import seedu.address.model.person.relationship.SpousesRelationship;
 
 /**
  * An Immutable AddressBook that is serializable to JSON format.
@@ -64,6 +68,7 @@ public JsonSerializableAddressBook(ReadOnlyAddressBook source) {
      */
     public AddressBook toModelType() throws IllegalValueException {
         AddressBook addressBook = new AddressBook();
+        HashMap<UUID, String> personGenders = new HashMap<>();
         for (JsonAdaptedPersonAttr jsonAdaptedPersonAttr : persons) {
             Person person = jsonAdaptedPersonAttr.toModelType();
             if (addressBook.hasPerson(person)) {
@@ -93,6 +98,46 @@ public AddressBook toModelType() throws IllegalValueException {
                             + relationship.getRelationshipDescriptor() + " found");
                 }
             }
+            if (relationship instanceof SiblingRelationship) {
+                SiblingRelationship siblingRelationship = (SiblingRelationship) relationship;
+                UUID person1Uuid = siblingRelationship.getPerson1();
+                UUID person2Uuid = siblingRelationship.getPerson2();
+                String rolePerson1 = siblingRelationship.getRole(person1Uuid);
+                String rolePerson2 = siblingRelationship.getRole(person2Uuid);
+
+                String person1Gender = rolePerson1.equals("brother") ? "male" : "female";
+                String person2Gender = rolePerson2.equals("brother") ? "male" : "female";
+
+                if (personGenders.containsKey(person1Uuid) && !personGenders.get(person1Uuid).equals(person1Gender)) {
+                    throw new IllegalValueException("Inconsistent gender for person with UUID " + person1Uuid);
+                }
+                if (personGenders.containsKey(person2Uuid) && !personGenders.get(person2Uuid).equals(person2Gender)) {
+                    throw new IllegalValueException("Inconsistent gender for person with UUID " + person2Uuid);
+                }
+
+                personGenders.put(person1Uuid, person1Gender);
+                personGenders.put(person2Uuid, person2Gender);
+            }
+            if (relationship instanceof SpousesRelationship) {
+                SpousesRelationship spousesRelationship = (SpousesRelationship) relationship;
+                UUID person1Uuid = spousesRelationship.getPerson1();
+                UUID person2Uuid = spousesRelationship.getPerson2();
+                String rolePerson1 = spousesRelationship.getRole(person1Uuid);
+                String rolePerson2 = spousesRelationship.getRole(person2Uuid);
+
+                String person1Gender = rolePerson1.equals("husband") ? "male" : "female";
+                String person2Gender = rolePerson2.equals("husband") ? "male" : "female";
+
+                if (personGenders.containsKey(person1Uuid) && !personGenders.get(person1Uuid).equals(person1Gender)) {
+                    throw new IllegalValueException("Inconsistent gender for person with UUID " + person1Uuid);
+                }
+                if (personGenders.containsKey(person2Uuid) && !personGenders.get(person2Uuid).equals(person2Gender)) {
+                    throw new IllegalValueException("Inconsistent gender for person with UUID " + person2Uuid);
+                }
+
+                personGenders.put(person1Uuid, person1Gender);
+                personGenders.put(person2Uuid, person2Gender);
+            }
             if (addressBook.hasRelationship(relationship)) {
                 throw new IllegalValueException("Duplicate relationship found.");
             }