Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UI bugs #123

Merged

Conversation

DingBao-sys
Copy link

No description provided.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.07%. Comparing base (3e18a44) to head (15239b3).
Report is 1 commits behind head on master.

Files Patch % Lines
...u/address/ui/personlistsection/AnyListSection.java 0.00% 6 Missing ⚠️
src/main/java/seedu/address/ui/PersonList.java 0.00% 3 Missing ⚠️
...u/address/logic/relationship/AnySearchCommand.java 50.00% 0 Missing and 1 partial ⚠️
...dress/ui/personlistsection/AllContactsSection.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
- Coverage     75.18%   75.07%   -0.11%     
- Complexity      796      797       +1     
============================================
  Files           116      116              
  Lines          2539     2544       +5     
  Branches        314      315       +1     
============================================
+ Hits           1909     1910       +1     
- Misses          546      549       +3     
- Partials         84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DingBao-sys
Copy link
Author

LGTM merge for demo

@DingBao-sys
Copy link
Author

UI code cannot be covered by test code

@DingBao-sys DingBao-sys requested a review from Tsenrae March 31, 2024 07:56
@DingBao-sys DingBao-sys self-assigned this Mar 31, 2024
@DingBao-sys DingBao-sys merged commit 6cc1f09 into AY2324S2-CS2103T-T11-1:master Mar 31, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant