made all commands non case sensitive #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
============================================
- Coverage 75.46% 73.07% -2.39%
Complexity 812 812
============================================
Files 116 117 +1
Lines 2617 2708 +91
Branches 327 334 +7
============================================
+ Hits 1975 1979 +4
- Misses 558 647 +89
+ Partials 84 82 -2 ☔ View full report in Codecov by Sentry. |
|
also added the functionality of shorthand. Each shorthand is just the first letter of each command. It means EditRelation == er and addAttribute == aa |
|
LGTM |
DingBao-sys
reviewed
Apr 3, 2024
Comment on lines
+86
to
105
| case FindCommand.COMMAND_WORD_SHORT: | ||
| return new FindCommandParser().parse(arguments); | ||
|
|
||
| case ListCommand.COMMAND_WORD: | ||
| case ListCommand.COMMAND_WORD_SHORT: | ||
| return new ListCommand(); | ||
|
|
||
| case ExitCommand.COMMAND_WORD: | ||
| case ExitCommand.COMMAND_WORD_SHORT: | ||
| return new ExitCommand(); | ||
|
|
||
| case HelpCommand.COMMAND_WORD: | ||
| case HelpCommand.COMMAND_WORD_SHORT: | ||
| return new HelpCommand(); | ||
|
|
||
| case AddRelationshipCommand.COMMAND_WORD: | ||
| case AddRelationshipCommand.COMMAND_WORD_SHORT: | ||
| return new AddRelationshipCommandParser().parse(arguments.trim()); | ||
|
|
||
| case DeleteRelationshipCommand.COMMAND_WORD: |
There was a problem hiding this comment.
I liked how you use case fall through pretty smart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commands now non case sensitive