Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Name, Phone and Address and update test cases to reflect new changes #151

Merged

Conversation

Tsenrae
Copy link

@Tsenrae Tsenrae commented Apr 2, 2024

No description provided.

@Tsenrae Tsenrae requested a review from Bandov April 2, 2024 18:41
@Tsenrae Tsenrae added the priority.high High priority label Apr 2, 2024
@Tsenrae Tsenrae added this to the v1.3 milestone Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (c5c8d41) to head (4b0cbf4).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
+ Coverage     71.83%   72.29%   +0.45%     
+ Complexity      759      751       -8     
============================================
  Files           113      110       -3     
  Lines          2553     2505      -48     
  Branches        315      310       -5     
============================================
- Hits           1834     1811      -23     
+ Misses          639      622      -17     
+ Partials         80       72       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tsenrae Tsenrae linked an issue Apr 2, 2024 that may be closed by this pull request
@Tsenrae Tsenrae linked an issue Apr 2, 2024 that may be closed by this pull request
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep i forgot to do that

Copy link

@Bandov Bandov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@Bandov Bandov merged commit fa35674 into AY2324S2-CS2103T-T11-1:master Apr 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate all out of date fields used in the AB3 Deprecate the old Person constructor (depends on #47)
2 participants