Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made find able to parse phrases and words instead of just finding words #176

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Bandov
Copy link

@Bandov Bandov commented Apr 4, 2024

No description provided.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.91%. Comparing base (eba336b) to head (cc5da80).
Report is 11 commits behind head on master.

Files Patch % Lines
...ss/model/person/NameContainsKeywordsPredicate.java 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #176      +/-   ##
============================================
- Coverage     73.05%   72.91%   -0.15%     
- Complexity      795      806      +11     
============================================
  Files           110      110              
  Lines          2628     2662      +34     
  Branches        338      348      +10     
============================================
+ Hits           1920     1941      +21     
- Misses          622      633      +11     
- Partials         86       88       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bandov
Copy link
Author

Bandov commented Apr 4, 2024

LGTM

@Bandov Bandov merged commit 6fbe705 into AY2324S2-CS2103T-T11-1:master Apr 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant