Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddRelationshipCommand to include checks for number of bioParents relationships (cannot be more than 2) #177

Merged

Conversation

Tsenrae
Copy link

@Tsenrae Tsenrae commented Apr 4, 2024

No description provided.

@Tsenrae Tsenrae requested a review from Emberlynn-Loo April 4, 2024 06:50
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 73.93%. Comparing base (83a241e) to head (0d3fb6a).
Report is 6 commits behind head on master.

Files Patch % Lines
...ess/logic/relationship/AddRelationshipCommand.java 82.75% 0 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #177      +/-   ##
============================================
+ Coverage     72.82%   73.93%   +1.11%     
- Complexity      802      818      +16     
============================================
  Files           110      108       -2     
  Lines          2653     2655       +2     
  Branches        345      359      +14     
============================================
+ Hits           1932     1963      +31     
+ Misses          633      599      -34     
- Partials         88       93       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Emberlynn-Loo Emberlynn-Loo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emberlynn-Loo Emberlynn-Loo merged commit b4f435c into AY2324S2-CS2103T-T11-1:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants