Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve delete behaviour #197

Conversation

ReflectiveObsidian
Copy link

Now, invalid format will have detailed explanations.

Before:
319216971-7d2b4dd5-9765-4e6b-855e-3af435f672f2
After:
image

Before:
319216926-3a595a85-5758-45e0-bdd0-d18715b00b66
After:
image

Before:
319217028-cf7351c1-d91c-4879-a215-9816c652e577
After:
image

Before:
319217546-a004f01a-bfd9-4b7f-821d-a29f7c47a5a1
After:
image

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.14%. Comparing base (e3bcceb) to head (ddda3e1).

❗ Current head ddda3e1 differs from pull request most recent head ecf7203. Consider uploading reports for the commit ecf7203 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
+ Coverage     74.08%   74.14%   +0.06%     
  Complexity      837      837              
============================================
  Files           108      108              
  Lines          2709     2704       -5     
  Branches        361      359       -2     
============================================
- Hits           2007     2005       -2     
- Misses          603      604       +1     
+ Partials         99       95       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Bandov Bandov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tsenrae Tsenrae merged commit 1f8a42a into AY2324S2-CS2103T-T11-1:master Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants