Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute mega update #265

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Conversation

Bandov
Copy link

@Bandov Bandov commented Apr 6, 2024

fixed multiple same attribute parsing for all classes that need attributes, fixed error messages not syncing up, fixed birthday attribute parsing and functionality

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.33%. Comparing base (94c1ac1) to head (fbb2db3).
Report is 2 commits behind head on master.

Files Patch % Lines
.../seedu/address/logic/parser/EditCommandParser.java 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #265      +/-   ##
============================================
+ Coverage     74.21%   74.33%   +0.11%     
- Complexity      842      853      +11     
============================================
  Files           108      108              
  Lines          2715     2735      +20     
  Branches        365      374       +9     
============================================
+ Hits           2015     2033      +18     
- Misses          601      602       +1     
- Partials         99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bandov Bandov merged commit 01547d7 into AY2324S2-CS2103T-T11-1:master Apr 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant