Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing testcases to person #32

Conversation

ReflectiveObsidian
Copy link

@ReflectiveObsidian ReflectiveObsidian commented Mar 11, 2024

No description provided.

@ReflectiveObsidian ReflectiveObsidian added the priority.urgent Urgent priority label Mar 11, 2024
@ReflectiveObsidian ReflectiveObsidian added this to the v1.2 milestone Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (08c6ce0) to head (e517c27).

❗ Current head e517c27 differs from pull request most recent head 9a56364. Consider uploading reports for the commit 9a56364 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
- Coverage     76.13%   75.96%   -0.18%     
+ Complexity      446      441       -5     
============================================
  Files            79       79              
  Lines          1387     1377      -10     
  Branches        128      127       -1     
============================================
- Hits           1056     1046      -10     
  Misses          301      301              
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReflectiveObsidian ReflectiveObsidian added priority.medium Medium priority and removed priority.urgent Urgent priority labels Mar 11, 2024
Copy link

@DingBao-sys DingBao-sys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ReflectiveObsidian ReflectiveObsidian merged commit e936246 into AY2324S2-CS2103T-T11-1:master Mar 12, 2024
3 checks passed
@ReflectiveObsidian ReflectiveObsidian deleted the person-testcases branch March 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.medium Medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants