Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teams feature #85

Merged
merged 12 commits into from
Mar 31, 2024
Merged

Add Teams feature #85

merged 12 commits into from
Mar 31, 2024

Conversation

angsongyee
Copy link
Collaborator

@angsongyee angsongyee commented Mar 26, 2024

Fixes #84
Adds the ability for users to create teams consisting of contacts.
This PR only adds the basic functionality for the feature. Only CLI output is planned for now, and a GUI update will be added in a later PR.

  • Added team to model
  • Integrated team with parser and storage
  • Implemented add delete and list team commands
  • Added tests
  • Updated UG and DG (Moved to another PR)

@angsongyee angsongyee added this to the v1.3 milestone Mar 26, 2024
@angsongyee angsongyee self-assigned this Mar 26, 2024
@angsongyee angsongyee marked this pull request as ready for review March 26, 2024 18:14
@angsongyee angsongyee requested review from a team, tanguoyang and Teeesa7 and removed request for a team March 26, 2024 18:14
Copy link
Collaborator

@Teeesa7 Teeesa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor changes, but overall, LGTM!! Reallyy nice work @angsongyee 👏

Copy link
Collaborator

@tanguoyang tanguoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some minor clarifications!

Copy link
Collaborator

@tanguoyang tanguoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some minor clarifications!

Copy link
Collaborator

@yuechen2001 yuechen2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think u wrote the tests pretty well i can't see any logical errors

Copy link
Collaborator

@tanguoyang tanguoyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fast work!

@angsongyee angsongyee merged commit ae2171b into master Mar 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a team of contacts
4 participants