Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix additem for single character #179

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Fix additem for single character #179

merged 3 commits into from
Apr 13, 2024

Conversation

kab-dot
Copy link

@kab-dot kab-dot commented Apr 12, 2024 •
edited
Loading

Fix #148

@khushi833
Fix the bug to allow a single character to be used for additem command
acb1973
@khushi833
Merge branch 'master' of https://github.com/AY2324S2-CS2103T-T13-4/tp …
c2c9ac8 
…into fix-additem-for-single-character

* 'master' of https://github.com/AY2324S2-CS2103T-T13-4/tp:
  Update UG
  Bug fixes
  Update landing page README.md
  Fix name parsing of addorder to be consistent with other commands
  Update addmempts to softmatch name with Persons in app
  Fix testcases and checkstyles
  Fix styling issues
  Update command error messages and improve find functionality
  Update user guide, gui screenshots and link to user guide
  Update error messages for some commands
  Fixed the help command, added additional commands
  Change commandword
@kab-dot kab-dot added this to the v1.4 milestone Apr 12, 2024
@kab-dot kab-dot self-assigned this Apr 12, 2024
@kab-dot kab-dot added severity.High A flaw which causes major problems for most users i.e. makes the product almost unusable bug.FeatureFlaw labels Apr 12, 2024
billyhoce
billyhoce approved these changes Apr 13, 2024
View reviewed changes
Copy link

@billyhoce billyhoce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kab-dot kab-dot merged commit 6133151 into AY2324S2-CS2103T-T13-4:master Apr 13, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyhoce billyhoce billyhoce approved these changes

Assignees

@kab-dot kab-dot

Labels
bug.FeatureFlaw severity.High A flaw which causes major problems for most users i.e. makes the product almost unusable
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Unable to add items with 1 character into catalogue
3 participants
@kab-dot @billyhoce @khushi833