Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UG fixes for v1.4 #183

Merged

Conversation

kab-dot
Copy link

@kab-dot kab-dot commented Apr 14, 2024

fix #163
fix #145

…into ug-fixes-for-v1.4

* 'master' of https://github.com/AY2324S2-CS2103T-T13-4/tp:
  Fix bug
  Revert changing of displayed points in person order panel
  Fix the bug to allow a single character to be used for additem command
  Fix checkstyle errors
  Fix GUI display of points in order panel of members
  Fixed reward and membership points of sample members
  Change Version Number to v1.3
@kab-dot kab-dot added type.Documentation Improvements or additions to documentation priority.High Must-haves for current milestone labels Apr 14, 2024
@kab-dot kab-dot added this to the v1.4 milestone Apr 14, 2024
@kab-dot kab-dot self-assigned this Apr 14, 2024
Copy link

@kinjalagarwal1810 kinjalagarwal1810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good now!! Love the pictures and the annotations you made. Also good that u picked up a few errors we had from before like the addmship

@@ -335,31 +337,32 @@ Format: `edit INDEX [n/MEMBER_NAME] [hp/MEMBER_PHONE] [e/MEMBER_EMAIL] [a/MEMBER
* At least one of the optional fields must be provided.
* Existing values will be updated to the input values.

* When editing allergens, the existing allergens of the member will be removed i.e adding of allergens is not cumulative.
* You can remove all the member’s allergens by typing `ag/` without specifying any allergens after it.
* When editing [allergens](#6-glossary), the existing [allergens](#6-glossary) of the member will be removed i.e adding of allergens is not cumulative.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think u needed to hyperlink every word HAHA but thank you looks v good a lot of effort to do that

Furthermore, certain edits can cause SweetRewards to behave in unexpected ways (e.g., if a value entered is outside of the acceptable range). Therefore, edit the data file only if you are confident that you can update it correctly.

--------------------------------------------------------------------------------------------------------------------

# 5. Glossary
# 5. Example Tutorial

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can say somewhere in the getting started or somewhere in the beginning that there is tutorial below. Hyperlink it to here if not those who don't scroll all the way down would not know there is a tutorial here

@kinjalagarwal1810 kinjalagarwal1810 merged commit 2196757 into AY2324S2-CS2103T-T13-4:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must-haves for current milestone type.Documentation Improvements or additions to documentation
Projects
None yet
3 participants