Fix edit command #104
Merged
Fix edit command #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-Tasks Added a visble tasklist to view all tasks done or not done.
when the person is assigned to a task and use edit command to change the name, it will change the task list person in charge's name to sync with the changes, however if the task has duplicate name, the code will break, can be solved by changing the equals method of task.java return task.personInCharge.equals(otherTask.personInCharge), but it will fail the edit command test, will solve it soon to pass CICD
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
============================================
+ Coverage 71.59% 72.00% +0.41%
- Complexity 641 649 +8
============================================
Files 110 110
Lines 2207 2215 +8
Branches 220 222 +2
============================================
+ Hits 1580 1595 +15
+ Misses 545 540 -5
+ Partials 82 80 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the person is assigned to a task and use edit command to change the name, it will change the task list person in charge's name to sync with the changes
however if the task has duplicate name, the code will break, can be solved by changing the equals method of task.java return task.personInCharge.equals(otherTask.personInCharge), but it will fail the edit command test, will solve it soon to pass CICD