add filter command #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
============================================
+ Coverage 75.46% 75.54% +0.07%
- Complexity 432 445 +13
============================================
Files 72 75 +3
Lines 1390 1427 +37
Branches 134 137 +3
============================================
+ Hits 1049 1078 +29
- Misses 309 314 +5
- Partials 32 35 +3 ☔ View full report in Codecov by Sentry. |
ziyi22
reviewed
Mar 29, 2024
| import seedu.address.model.person.PersonContainsKeywordsPredicate; | ||
|
|
||
| /** | ||
| * Finds and lists all persons in address book whose name contains any of the argument keywords. |
There was a problem hiding this comment.
Some typo in the java doc comments. Should be 'whose department or tags'
ziyi22
reviewed
Mar 29, 2024
| FilterCommand command = new FilterCommand(predicate); | ||
| expectedModel.updateFilteredPersonList(predicate); | ||
| assertCommandSuccess(command, model, expectedMessage, expectedModel); | ||
| assertEquals(Arrays.asList(CARL, DANIEL), model.getFilteredPersonList()); |
There was a problem hiding this comment.
Great work on testing the scenario of filtering based on multiple keywords.
ziyi22
reviewed
Mar 29, 2024
| import seedu.address.commons.util.ToStringBuilder; | ||
|
|
||
| /** | ||
| * Tests that a {@code Person}'s {@code Name} matches any of the keywords given. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.