forked from nus-cs2103-AY2324S2/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement feature: Assign tasks to specific persons #58
Merged
ziyi22
merged 12 commits into
AY2324S2-CS2103T-T14-1:master
from
ziyi22:branch-AssignTask
Mar 20, 2024
Merged
Implement feature: Assign tasks to specific persons #58
ziyi22
merged 12 commits into
AY2324S2-CS2103T-T14-1:master
from
ziyi22:branch-AssignTask
Mar 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howen02
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yiwern5
reviewed
Mar 29, 2024
@@ -92,6 +112,45 @@ public void setPerson(Person target, Person editedPerson) { | |||
*/ | |||
public void removePerson(Person key) { | |||
persons.remove(key); | |||
tasks.remove(key.getTask()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line would throw an NullPointerException if the person do not have any task.
Suggested change
tasks.remove(key.getTask()); | |
Task task = key.getTask(); | |
if (task != null) { | |
tasks.remove(key.getTask()); | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to assign tasks to specific persons in EffiTrack. Modified Task class to include a reference to the Person responsible for the task. Updated UniqueTaskList and AssignTaskCommand to handle the assignment of tasks to persons. Also added validation checks to ensure that a person can only have one task assigned at a time. Implemented necessary changes to ensure data consistency and integrity within the application.