Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch efficiency #59

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Conversation

howen02
Copy link

@howen02 howen02 commented Mar 21, 2024

Implement efficiency metrics and UI changes.

Copy link
Collaborator

@yiwern5 yiwern5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 71.83099% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 73.51%. Comparing base (31cd0de) to head (fffa4e8).

Files Patch % Lines
...in/java/seedu/address/model/person/Efficiency.java 50.00% 7 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 6 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 60.00% 1 Missing and 1 partial ⚠️
src/main/java/seedu/address/model/task/Task.java 75.00% 2 Missing ⚠️
...in/java/seedu/address/storage/JsonAdaptedTask.java 66.66% 1 Missing and 1 partial ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
- Coverage     73.59%   73.51%   -0.08%     
- Complexity      494      503       +9     
============================================
  Files            84       85       +1     
  Lines          1632     1680      +48     
  Branches        161      166       +5     
============================================
+ Hits           1201     1235      +34     
- Misses          373      385      +12     
- Partials         58       60       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@howen02 howen02 merged commit 11c0a88 into AY2324S2-CS2103T-T14-1:master Mar 21, 2024
3 of 5 checks passed
@howen02 howen02 self-assigned this Mar 21, 2024
@howen02 howen02 added this to the v1.2 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a HR Manager, I can generate efficiency reports highlighting significant changes
2 participants