Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made new ReassignTaskCommand #78

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

KiatLun
Copy link

@KiatLun KiatLun commented Mar 29, 2024

No description provided.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 6.25000% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 72.10%. Comparing base (d53a48e) to head (d50b848).

❗ Current head d50b848 differs from pull request most recent head b763fcc. Consider uploading reports for the commit b763fcc to get more accurate results

Files Patch % Lines
...du/address/logic/commands/ReassignTaskCommand.java 7.14% 26 Missing ⚠️
...ddress/logic/parser/ReassignTaskCommandParser.java 0.00% 9 Missing ⚠️
src/main/java/seedu/address/model/AddressBook.java 0.00% 5 Missing ⚠️
...rc/main/java/seedu/address/model/ModelManager.java 0.00% 3 Missing ⚠️
.../seedu/address/logic/commands/MarkTaskCommand.java 0.00% 1 Missing ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #78      +/-   ##
============================================
- Coverage     72.46%   72.10%   -0.36%     
- Complexity      569      572       +3     
============================================
  Files            98       98              
  Lines          1921     1936      +15     
  Branches        191      195       +4     
============================================
+ Hits           1392     1396       +4     
- Misses          464      475      +11     
  Partials         65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@wolffe88 wolffe88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

requireAllNonNull(fromIndex, toIndex);
this.fromIndex = fromIndex;
this.toIndex = toIndex;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code does not seem to be covered by test

public static final String MESSAGE_REASSIGN_TASK_SUCCESS = "Reassigned task %1$s from %2$s to %3$s successfully";

public static final String MESSAGE_USAGE = COMMAND_WORD
+ ": Reassigns a task to a person identified by index number.\n"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat formatting!

@@ -105,6 +106,9 @@ public Command parseCommand(String userInput) throws ParseException {
case FilterEfficiencyCommand.COMMAND_WORD:
return new FilterEfficiencyCommandParser().parse(arguments);

case ReassignTaskCommand.COMMAND_WORD:
return new ReassignTaskCommandParser().parse(arguments);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method in this file is not covered with testing too

/**
* Parse input arguments and create a new ReassignTaskCommand object.
*/
public class ReassignTaskCommandParser implements Parser<ReassignTaskCommand> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method in this file is not covered by tests

@@ -15,6 +15,7 @@ public class CliSyntax {
public static final Prefix PREFIX_TASK = new Prefix("task/");
public static final Prefix PREFIX_DEADLINE = new Prefix("by/");
public static final Prefix PREFIX_TO = new Prefix("to/");
public static final Prefix PREFIX_FROM = new Prefix("from/");
public static final Prefix PREFIX_EFFICIENCY = new Prefix("eff/");
public static final Prefix PREFIX_TASK_OWNER = new Prefix("o/");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the prefix could be better. Maybe something like by instead of o as o is quite vague

@KiatLun KiatLun merged commit 9c11cba into AY2324S2-CS2103T-T14-1:master Mar 29, 2024
0 of 3 checks passed
@yiwern5 yiwern5 added this to the v1.3 milestone Apr 1, 2024
@yiwern5 yiwern5 linked an issue Apr 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a HR Manager, I can change person in charge of a task
3 participants