-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made new ReassignTaskCommand #78
Made new ReassignTaskCommand #78
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
============================================
- Coverage 72.46% 72.10% -0.36%
- Complexity 569 572 +3
============================================
Files 98 98
Lines 1921 1936 +15
Branches 191 195 +4
============================================
+ Hits 1392 1396 +4
- Misses 464 475 +11
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
requireAllNonNull(fromIndex, toIndex); | ||
this.fromIndex = fromIndex; | ||
this.toIndex = toIndex; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code does not seem to be covered by test
public static final String MESSAGE_REASSIGN_TASK_SUCCESS = "Reassigned task %1$s from %2$s to %3$s successfully"; | ||
|
||
public static final String MESSAGE_USAGE = COMMAND_WORD | ||
+ ": Reassigns a task to a person identified by index number.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
neat formatting!
@@ -105,6 +106,9 @@ public Command parseCommand(String userInput) throws ParseException { | |||
case FilterEfficiencyCommand.COMMAND_WORD: | |||
return new FilterEfficiencyCommandParser().parse(arguments); | |||
|
|||
case ReassignTaskCommand.COMMAND_WORD: | |||
return new ReassignTaskCommandParser().parse(arguments); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the method in this file is not covered with testing too
/** | ||
* Parse input arguments and create a new ReassignTaskCommand object. | ||
*/ | ||
public class ReassignTaskCommandParser implements Parser<ReassignTaskCommand> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the method in this file is not covered by tests
@@ -15,6 +15,7 @@ public class CliSyntax { | |||
public static final Prefix PREFIX_TASK = new Prefix("task/"); | |||
public static final Prefix PREFIX_DEADLINE = new Prefix("by/"); | |||
public static final Prefix PREFIX_TO = new Prefix("to/"); | |||
public static final Prefix PREFIX_FROM = new Prefix("from/"); | |||
public static final Prefix PREFIX_EFFICIENCY = new Prefix("eff/"); | |||
public static final Prefix PREFIX_TASK_OWNER = new Prefix("o/"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the prefix could be better. Maybe something like by instead of o as o is quite vague
No description provided.