Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch fix undo #82

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Conversation

yiwern5
Copy link
Collaborator

@yiwern5 yiwern5 commented Mar 29, 2024

Able to undo assign task and mark task as done now

yiwern5 added 4 commits March 28, 2024 15:50
Assign task and mark task as done command now uses immutable Task instance to allow versioned addressbook to capture the previous address book state
Assign task and mark task as done command now uses immutable Task instance to allow versioned addressbook to capture the previous address book state
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 70.42%. Comparing base (d5ed04d) to head (1fe22bd).
Report is 19 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/model/AddressBook.java 40.00% 9 Missing ⚠️
.../java/seedu/address/model/task/UniqueTaskList.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
- Coverage     73.63%   70.42%   -3.22%     
- Complexity      568      573       +5     
============================================
  Files            96      100       +4     
  Lines          1889     1988      +99     
  Branches        187      201      +14     
============================================
+ Hits           1391     1400       +9     
- Misses          433      523      +90     
  Partials         65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@howen02 howen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add tests!

@yiwern5 yiwern5 merged commit 2958d8c into AY2324S2-CS2103T-T14-1:master Mar 29, 2024
3 of 5 checks passed
@yiwern5 yiwern5 added this to the v1.3 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants