Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Find Task Command #90

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

howen02
Copy link

@howen02 howen02 commented Apr 3, 2024

User can now find person in charge of a task with this command. Task finding is case-insentitive

User can now find person in charge of a task with this command. Task finding is case-insentitive
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.74%. Comparing base (c9983e8) to head (8247414).

Files Patch % Lines
...ss/model/person/TaskContainsKeywordsPredicate.java 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #90      +/-   ##
============================================
+ Coverage     72.31%   72.74%   +0.42%     
- Complexity      597      614      +17     
============================================
  Files           100      103       +3     
  Lines          2030     2069      +39     
  Branches        206      209       +3     
============================================
+ Hits           1468     1505      +37     
- Misses          485      486       +1     
- Partials         77       78       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ziyi22 ziyi22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howen02 howen02 merged commit 5110f9e into AY2324S2-CS2103T-T14-1:master Apr 3, 2024
5 checks passed
@ziyi22 ziyi22 added this to the v1.3b milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a HR manager, I can find the person in charge for a task to keep accountability
2 participants