Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment command #94

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Conversation

wolffe88
Copy link

@wolffe88 wolffe88 commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 72.85714% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 72.95%. Comparing base (937eddb) to head (3f9800e).
Report is 2 commits behind head on master.

Files Patch % Lines
...a/seedu/address/logic/commands/CommentCommand.java 72.00% 2 Missing and 5 partials ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 14.28% 6 Missing ⚠️
...edu/address/logic/parser/CommentCommandParser.java 77.77% 2 Missing ⚠️
src/main/java/seedu/address/model/AddressBook.java 33.33% 2 Missing ⚠️
.../main/java/seedu/address/model/person/Comment.java 92.30% 1 Missing ⚠️
...c/main/java/seedu/address/model/person/Person.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     72.74%   72.95%   +0.21%     
- Complexity      614      630      +16     
============================================
  Files           103      106       +3     
  Lines          2069     2126      +57     
  Branches        209      214       +5     
============================================
+ Hits           1505     1551      +46     
- Misses          486      492       +6     
- Partials         78       83       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ziyi22 ziyi22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolffe88 wolffe88 merged commit 212a794 into AY2324S2-CS2103T-T14-1:master Apr 4, 2024
5 checks passed
@wolffe88 wolffe88 added this to the v1.3b milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a HR Manager, I would like to add comments about employees so that I can make notes
2 participants