Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more data formats for schedule command #122

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

cheahTJ
Copy link

@cheahTJ cheahTJ commented Apr 2, 2024

No description provided.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 80.87432% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 76.07%. Comparing base (565d98e) to head (d5df41c).
Report is 165 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/ui/PersonCard.java 0.00% 18 Missing ⚠️
...va/seedu/address/logic/commands/DeleteCommand.java 63.15% 10 Missing and 4 partials ⚠️
...seedu/address/logic/parser/GroupCommandParser.java 63.33% 2 Missing and 9 partials ⚠️
...ava/seedu/address/logic/commands/GroupCommand.java 87.14% 2 Missing and 7 partials ⚠️
...du/address/model/person/GroupMatchesPredicate.java 73.91% 3 Missing and 3 partials ⚠️
.../seedu/address/logic/parser/AddressBookParser.java 33.33% 2 Missing ⚠️
...eedu/address/logic/parser/DeleteCommandParser.java 81.81% 1 Missing and 1 partial ⚠️
...du/address/model/person/EmailMatchesPredicate.java 86.66% 1 Missing and 1 partial ⚠️
...du/address/model/person/PhoneMatchesPredicate.java 86.66% 1 Missing and 1 partial ⚠️
...eedu/address/model/person/TagMatchesPredicate.java 88.23% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #122      +/-   ##
============================================
+ Coverage     75.41%   76.07%   +0.65%     
- Complexity      470      560      +90     
============================================
  Files            76       84       +8     
  Lines          1501     1822     +321     
  Branches        148      197      +49     
============================================
+ Hits           1132     1386     +254     
- Misses          332      370      +38     
- Partials         37       66      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjuntan
Copy link

hjuntan commented Apr 2, 2024

More schedule formats to improve user friendliness

@hjuntan hjuntan merged commit b2f813e into master Apr 2, 2024
8 checks passed
@hjuntan hjuntan added this to the v1.3 milestone Apr 2, 2024
@hjuntan hjuntan linked an issue Apr 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to use different date formats in schedule command
3 participants