Abstract logic out and standardise invalid command messages #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## code-quality #128 +/- ##
==================================================
+ Coverage 76.09% 76.16% +0.07%
+ Complexity 563 562 -1
==================================================
Files 84 84
Lines 1820 1817 -3
Branches 198 198
==================================================
- Hits 1385 1384 -1
+ Misses 369 367 -2
Partials 66 66 ☔ View full report in Codecov by Sentry. |
hjuntan
reviewed
Apr 2, 2024
| * @return A person, if any, with the corresponding nusId | ||
| */ | ||
| @Override | ||
| public Person filterPersonListWithNusId(NusId nusId) { |
There was a problem hiding this comment.
Can you add some test cases for this method? Two is more than enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.