Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove File system for CommandHistory #145

Conversation

RingoftheKing
Copy link

It is unlikely for a Prof, TA, student
to reuse commands from a previous session.

Remove file reading due to above reason.

It is unlikely for a Prof, TA, student
to reuse a command from a previous session.

Remove file reading due to above reason.
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.49%. Comparing base (c5a0622) to head (3b54ddb).
Report is 1 commits behind head on add-up-down-keypress-functionality.

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##             add-up-down-keypress-functionality     #145      +/-   ##
========================================================================
+ Coverage                                 73.38%   74.49%   +1.10%     
+ Complexity                                  573      572       -1     
========================================================================
  Files                                        86       85       -1     
  Lines                                      1924     1890      -34     
  Branches                                    203      202       -1     
========================================================================
- Hits                                       1412     1408       -4     
+ Misses                                      443      413      -30     
  Partials                                     69       69              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjuntan
Copy link

hjuntan commented Apr 3, 2024

Removes files that stores the commands history

@hjuntan hjuntan merged commit c11b4c8 into AY2324S2-CS2103T-T15-2:add-up-down-keypress-functionality Apr 3, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants