Edit inconsistency in schedule command in UG #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjuntan
reviewed
Apr 10, 2024
| > * Both `schedule` and `remark` must be either provided or not provided. | ||
| > * If `schedule` and `remark` are not provided, the schedule will be removed. | ||
|
|
||
| **Tip:** The `schedule` must be in one of the formats: `DD/MM/YYYY`, `DD-MM-YYYY`, `DD.MM.YYYY`, `MMM DD, YYYY`, `DD MMM YYYY`. | ||
| **Tip:** The `schedule` must be in one of the formats: `DD/MM/YYYY`, `DD-MM-YYYY`, `DD.MM.YYYY`, `MMM DD, YYYY`, `DD MMM YYYY`. Example of date formats include: `12-12-2024`, `12/12/2024`, `12.12.2024`, `Dec 12, 2024`, `12 Dec 2024`. |
There was a problem hiding this comment.
Giving examples to MMM to address issue #175 when the user does not know the that MMM corresponds to the 3-letter abbreviation of the month .
| @@ -244,21 +244,21 @@ Format: `group [id/NUSID] [g/GROUP] [t/TAG]` | |||
|
|
|||
| Schedule a meeting with a person in the address book. | |||
|
|
|||
| Format: `schedule id/NUSID [s/SCHEDULE] [r/REMARK]` | |||
| Format: `schedule id/NUSID [s/SCHEDULE r/REMARK]` | |||
There was a problem hiding this comment.
Fix consistency that schedule and remark must be either both present or both absent.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.