Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update regexes to accept valid name/group strings" #242

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

Ragnapop
Copy link

Reverts #231

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (2c7215a) to head (8e3659b).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #242   +/-   ##
=========================================
  Coverage     75.12%   75.12%           
  Complexity      602      602           
=========================================
  Files            88       88           
  Lines          1946     1946           
  Branches        210      210           
=========================================
  Hits           1462     1462           
  Misses          416      416           
  Partials         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjuntan
Copy link

hjuntan commented Apr 11, 2024

Remove change in validation regex in name and group due to violation in feature freeze. The original validation regex in group name is "[\p{Alnum}][\p{Alnum} ]*" and requires in more revert.

@hjuntan hjuntan merged commit cd0f782 into master Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants