Add duplicate UID check in JSON #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new feature where the system checks for duplicate UIDs in the JSON file. If duplicates are found, the system starts with the default template. This is to ensure data integrity and prevent potential issues caused by duplicate UIDs. This feature is crucial for maintaining the uniqueness of UIDs in our system. It prevents the system from processing the same UID twice, which could lead to unexpected behavior or errors. By starting with the default template when duplicates are found, we ensure that the system can continue to function normally while the user investigates the source of the duplicate UIDs.
This was
linked to
issues
Apr 13, 2024
hjungwoo01
approved these changes
Apr 13, 2024
| * | ||
| * @return true if duplicate UIDs are present, else false | ||
| */ | ||
| public boolean hasDuplicateUids() { |
| @@ -55,6 +63,10 @@ public Optional<ReadOnlyAddressBook> readAddressBook(Path filePath) throws DataL | |||
| try { | |||
| JsonSerializableAddressBook addressBook = jsonAddressBook.get(); | |||
| Integer maxUid = addressBook.getMaxUid(); | |||
| if (addressBook.hasDuplicateUids()) { | |||
| logger.warning(DUPLICATE_UID_WARNING); | |||
| @@ -7,6 +7,8 @@ | |||
| * Todo: Add validation for uid | |||
| */ | |||
| public class UniqueId { | |||
| public static final Integer DEFAULT_BASE_UID = 100; | |||
src/main/java/seedu/address/storage/JsonSerializableAddressBook.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new feature where the system checks for duplicate UIDs in the JSON file. If duplicates are found, the system starts with the default template.
This is to ensure data integrity and prevent potential issues caused by duplicate UIDs. This feature is crucial for maintaining the uniqueness of UIDs in our system.
It prevents the system from processing the same UID twice, which could lead to unexpected behavior or errors.
By starting with the default template when duplicates are found, we ensure that the system can continue to function normally while the user investigates the source of the duplicate UIDs.