Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AddressBook to FitBook in log message #357

Merged

Conversation

dillontkh
Copy link
Collaborator

Found 1 more occurrence of "AddressBook" (the app name) being referenced in the logging messages.

@dillontkh dillontkh added this to the v1.4 milestone Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.04%. Comparing base (7830414) to head (27ec781).
Report is 4 commits behind head on master.

Files Patch % Lines
src/main/java/seedu/address/MainApp.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #357   +/-   ##
=========================================
  Coverage     69.04%   69.04%           
  Complexity      766      766           
=========================================
  Files           128      128           
  Lines          2736     2736           
  Branches        290      290           
=========================================
  Hits           1889     1889           
  Misses          736      736           
  Partials        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jjchee77 jjchee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@RyanNgWH RyanNgWH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Collaborator

@ruijietay ruijietay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruijietay ruijietay merged commit 1dd7972 into AY2324S2-CS2103T-T17-3:master Apr 14, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants