Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Storage and GUI for Appointment #61

Merged
merged 9 commits into from
Mar 23, 2024

Conversation

MaYuehan
Copy link

@MaYuehan MaYuehan commented Mar 17, 2024

Implement the GUI for Appointment functions. #55
Add appointment list to storage. #66
Will fix the Junit test for createAptCommandTest class later.

@MaYuehan MaYuehan added this to the V1.2b milestone Mar 17, 2024
@MaYuehan MaYuehan self-assigned this Mar 17, 2024
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 53.25444% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 68.84%. Comparing base (027086d) to head (a4ab407).

Files Patch % Lines
src/main/java/vitalconnect/MainApp.java 0.00% 13 Missing ⚠️
src/main/java/vitalconnect/ui/MainWindow.java 0.00% 13 Missing ⚠️
src/main/java/vitalconnect/ui/AppointmentCard.java 0.00% 12 Missing ⚠️
...ain/java/vitalconnect/ui/AppointmentListPanel.java 0.00% 12 Missing ⚠️
.../vitalconnect/logic/commands/CreateAptCommand.java 38.46% 7 Missing and 1 partial ⚠️
src/main/java/vitalconnect/model/ModelManager.java 33.33% 5 Missing and 1 partial ⚠️
src/main/java/vitalconnect/model/Appointment.java 54.54% 1 Missing and 4 partials ⚠️
src/main/java/vitalconnect/model/UserPrefs.java 83.33% 1 Missing and 1 partial ⚠️
...a/vitalconnect/storage/JsonAdaptedAppointment.java 88.23% 1 Missing and 1 partial ⚠️
...a/vitalconnect/storage/JsonAppointmentStorage.java 90.47% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #61      +/-   ##
============================================
- Coverage     71.02%   68.84%   -2.19%     
- Complexity      559      578      +19     
============================================
  Files            93       98       +5     
  Lines          1826     1961     +135     
  Branches        192      203      +11     
============================================
+ Hits           1297     1350      +53     
- Misses          455      529      +74     
- Partials         74       82       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaYuehan MaYuehan changed the title Implement the GUI for Appointment functions Implement the Storage and GUI for Appointment Mar 23, 2024
Copy link

@Ella-e Ella-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -89,7 +90,9 @@ public interface Model {
void updateFilteredPersonList(Predicate<Person> predicate);

boolean doesPersonExist(String name);
boolean doesIcExist(String name);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'boolean doesIcExist(String nric)'

@Ella-e Ella-e merged commit 1077086 into AY2324S2-CS2103T-W08-2:master Mar 23, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants