Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat appointment command #84

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

Ella-e
Copy link

@Ella-e Ella-e commented Mar 26, 2024

Change adda format to : 'adda ic/ NRIC time/ dd/MM/yyyy HHmm'
Change deletea format to : "deletea INDEX"

@Ella-e Ella-e added this to the v1.3 milestone Mar 26, 2024
@Ella-e Ella-e self-assigned this Mar 26, 2024
@Ella-e Ella-e requested a review from MaYuehan March 26, 2024 04:34
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 67.73%. Comparing base (bac086e) to head (19321be).

Files Patch % Lines
.../vitalconnect/logic/commands/CreateAptCommand.java 46.66% 7 Missing and 1 partial ⚠️
...alconnect/logic/parser/CreateAptCommandParser.java 61.53% 1 Missing and 4 partials ⚠️
...ain/java/vitalconnect/logic/parser/ParserUtil.java 60.00% 2 Missing ⚠️
.../vitalconnect/logic/commands/DeleteAptCommand.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     67.55%   67.73%   +0.18%     
+ Complexity      585      584       -1     
============================================
  Files           100      100              
  Lines          2022     2021       -1     
  Branches        214      215       +1     
============================================
+ Hits           1366     1369       +3     
+ Misses          575      569       -6     
- Partials         81       83       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@MaYuehan MaYuehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and commands' format become more consistent.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@MaYuehan MaYuehan merged commit 91e46c2 into AY2324S2-CS2103T-W08-2:master Mar 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants