Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalise prefix #221

Merged

Conversation

yleeyilin
Copy link

No description provided.

* 'master' of github.com:AY2324S2-CS2103T-W10-2/tp:
  Standardise ug language
  Refactor storage file
  Remove logger from RatePredicate
  Refactor storage file name
  Fix checkstyle
  Add loggers and update messages
* 'master' of github.com:AY2324S2-CS2103T-W10-2/tp:
  Fix checkstyle
  Fix commit
  Remove redundancy
  Fix edit bug
@yleeyilin yleeyilin added this to the v1.3 milestone Apr 4, 2024
@yleeyilin yleeyilin requested a review from jannaleong April 4, 2024 14:11
@yleeyilin yleeyilin self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.12%. Comparing base (61fe74e) to head (bdbd522).
Report is 8 commits behind head on master.

Files Patch % Lines
...in/java/seedu/address/logic/parser/ParserUtil.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #221      +/-   ##
============================================
+ Coverage     75.97%   76.12%   +0.14%     
- Complexity      867      870       +3     
============================================
  Files           130      130              
  Lines          3130     3141      +11     
  Branches        351      353       +2     
============================================
+ Hits           2378     2391      +13     
+ Misses          624      621       -3     
- Partials        128      129       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jannaleong jannaleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jannaleong jannaleong merged commit 7d54a9e into AY2324S2-CS2103T-W10-2:master Apr 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants