Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort by tags #223

Merged

Conversation

Joshy837
Copy link

@Joshy837 Joshy837 commented Apr 4, 2024

No description provided.

Joshy837 added 2 commits April 4, 2024 23:14
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp:
  Update sort pin behaviour
  Update name constraints
  Fix checkstyle
  Fix search format
  Normalise prefix
  Fix test
  Add sort tests
  Add sort tests
  Fix checkstyle
  Fix commit
  Remove redundancy
  Fix edit bug
  Standardise ug language
  Refactor storage file
  Remove logger from RatePredicate
  Refactor storage file name
  Fix checkstyle
  Add loggers and update messages
@Joshy837 Joshy837 added this to the v1.3 milestone Apr 4, 2024
@Joshy837 Joshy837 self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.61%. Comparing base (2719eb2) to head (f0de098).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #223   +/-   ##
=========================================
  Coverage     76.61%   76.61%           
  Complexity      876      876           
=========================================
  Files           130      130           
  Lines          3143     3143           
  Branches        353      353           
=========================================
  Hits           2408     2408           
  Misses          606      606           
  Partials        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannaleong jannaleong removed this from the v1.3 milestone Apr 4, 2024
Copy link

@yleeyilin yleeyilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yleeyilin yleeyilin merged commit 09fb7f2 into AY2324S2-CS2103T-W10-2:master Apr 4, 2024
5 checks passed
@yleeyilin yleeyilin removed the request for review from jamessinmaojun April 4, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants