Standardize error messages #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joshy837
approved these changes
Apr 4, 2024
| @@ -4,7 +4,7 @@ | |||
| * Container for user redo command visible messages. | |||
| */ | |||
| public class RedoMessages extends Messages { | |||
| public static final String MESSAGE_REDO_SUCCESS = "Woof! Redo successfully! \uD83D\uDC36"; | |||
| public static final String MESSAGE_REDO_FAIL = "Woof! There is no more future state to redo!"; | |||
| public static final String MESSAGE_REDO_SUCCESS = "Woof! Redo successful! \uD83D\uDC36"; | |||
| @@ -4,9 +4,9 @@ | |||
| * Container for user search command visible messages. | |||
| */ | |||
| public class SearchMessages extends Messages { | |||
| public static final String MESSAGE_SEARCH_PERSON_SUCCESS = "Woof! %1$s contacts found! \uD83D\uDC36"; | |||
| public static final String MESSAGE_SEARCH_PERSON_SUCCESS = "Woof! %1$s contact(s) found! \uD83D\uDC36"; | |||
There was a problem hiding this comment.
Good change of separating contact & contacts
| @@ -4,7 +4,7 @@ | |||
| * Container for user undo command visible messages. | |||
| */ | |||
| public class UndoMessages extends Messages { | |||
| public static final String MESSAGE_UNDO_SUCCESS = "Woof! Undo successfully! \uD83D\uDC36"; | |||
| public static final String MESSAGE_UNDO_FAIL = "Woof! There is no more previous state to undo!"; | |||
| public static final String MESSAGE_UNDO_SUCCESS = "Woof! Undo successful! \uD83D\uDC36"; | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #228 +/- ##
============================================
+ Coverage 76.40% 76.44% +0.03%
Complexity 880 880
============================================
Files 130 132 +2
Lines 3158 3171 +13
Branches 356 356
============================================
+ Hits 2413 2424 +11
- Misses 614 616 +2
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the TP Feature Testing Document.