Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check DG #316

Merged
merged 7 commits into from
Apr 14, 2024
Merged

Check DG #316

merged 7 commits into from
Apr 14, 2024

Conversation

yleeyilin
Copy link

No description provided.

* 'master' of github.com:AY2324S2-CS2103T-W10-2/tp:
  Update dg
  Fix grammar issues
  Add alternatives to DG for rate and delete
  Fix checkstyle
  Fix issues
  Standardise ug
  Update code consideration alternative in dg
  Update code quality
  Replace constant values with constant variables
  Standardise code
  Update code quality for argument tokenizer
  Checkstyle checking
  Abstract out Messages and reduce repeated code
  Fix sort abstraction
  Add sort by pin
  Improve code quality
  Fix sort note ordering
* 'master' of github.com:AY2324S2-CS2103T-W10-2/tp:
  Improve comments for testcase
  Improve code quality
  Checkstyle update
  Update DG
  Add manual testing for sort and search
  Update manual testing for add, undo and redo
@yleeyilin yleeyilin self-assigned this Apr 13, 2024
@yleeyilin yleeyilin added this to the v1.4 milestone Apr 13, 2024
@yleeyilin yleeyilin added the priority.High Must do label Apr 13, 2024
Copy link

@jannaleong jannaleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but minor errors

Copy link

@chiageng chiageng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannaleong jannaleong removed the request for review from jamessinmaojun April 14, 2024 02:50
@jannaleong jannaleong merged commit 00fc8f5 into AY2324S2-CS2103T-W10-2:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants