Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DG #320

Merged
merged 9 commits into from
Apr 14, 2024
Merged

Fix DG #320

merged 9 commits into from
Apr 14, 2024

Conversation

Joshy837
Copy link

Fix spelling n wording

* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp:
  Update code consideration alternative in dg
  Update code quality
  Replace constant values with constant variables
  Standardise code
  Update code quality for argument tokenizer
  Checkstyle checking
  Abstract out Messages and reduce repeated code
  Update code quality
  Update catch quality
  Update code quality
  Fixed code quality
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp:
  Update dg
  Fix grammar issues
  Add alternatives to DG for rate and delete
  Fix checkstyle
  Fix issues
  Standardise ug
  Fix sort abstraction
  Add sort by pin
  Improve code quality
  Fix sort note ordering
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp:
  Fix grammar in dg manual testing
  Add enhancement
  Add sort command parser tests
  Update comments
  Add line
  Update enhancement
  Minor grammar fixes
  Fix UG errors
  Fix UG errors
  Improve comments for testcase
  Improve code quality
  Checkstyle update
  Update DG
  Add manual testing for sort and search
  Update manual testing for add, undo and redo
@Joshy837 Joshy837 added this to the v1.4 milestone Apr 14, 2024
@Joshy837 Joshy837 self-assigned this Apr 14, 2024
Copy link

@yleeyilin yleeyilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment to be fixed

```

2. Test case: `/note ; name : Poochie ; note : get kibble ; deadline : 2020-10-10`<br>
Expected: Woof! Added note to Pooch Contact Supplier PetCo successfully! 🐶

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is Poochie, should not be PetCo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@Joshy837 Joshy837 requested a review from yleeyilin April 14, 2024 12:32
Copy link

@chiageng chiageng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannaleong jannaleong requested review from jannaleong and removed request for yleeyilin and jamessinmaojun April 14, 2024 13:06
Copy link

@yleeyilin yleeyilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yleeyilin yleeyilin merged commit 2e699c3 into AY2324S2-CS2103T-W10-2:master Apr 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants