-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DG #320
Fix DG #320
Conversation
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp: Update code consideration alternative in dg Update code quality Replace constant values with constant variables Standardise code Update code quality for argument tokenizer Checkstyle checking Abstract out Messages and reduce repeated code Update code quality Update catch quality Update code quality Fixed code quality
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp: Update dg Fix grammar issues Add alternatives to DG for rate and delete Fix checkstyle Fix issues Standardise ug Fix sort abstraction Add sort by pin Improve code quality Fix sort note ordering
* 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp: Fix grammar in dg manual testing Add enhancement Add sort command parser tests Update comments Add line Update enhancement Minor grammar fixes Fix UG errors Fix UG errors Improve comments for testcase Improve code quality Checkstyle update Update DG Add manual testing for sort and search Update manual testing for add, undo and redo
…into branch-fix-dg * 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp: Correct dg phrasing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment to be fixed
docs/DeveloperGuide.md
Outdated
``` | ||
|
||
2. Test case: `/note ; name : Poochie ; note : get kibble ; deadline : 2020-10-10`<br> | ||
Expected: Woof! Added note to Pooch Contact Supplier PetCo successfully! 🐶 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name is Poochie, should not be PetCo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved
…into branch-fix-dg * 'master' of https://github.com/AY2324S2-CS2103T-W10-2/tp: Fix ug bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fix spelling n wording