Add validation to ensure valid moduleCode #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this hinges on the fact that I can get reading module_data working in shadowJar files... |
|
Fixed the shadowjar issue. Whoever is reviewing this, if you don't mind, pls checkout this branch and run
|
yadunut
force-pushed
the
fix-duplicate-modules
branch
from
c789b5f to
72bf467
Compare
blaukc
approved these changes
Apr 7, 2024
src/main/java/seedu/address/logic/parser/ListModulesCommandParser.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #70.
By proxy, this PR also closes #72, closes #84. However would like to double check for this one.
Closes #110.
Closes #108.
Closes #91.
Closes #105.
Closes #122.
Closes #104.
Closes #78.