Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to explain tags can not process white spaces #126

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

AdityaB4
Copy link

@AdityaB4 AdityaB4 commented Apr 9, 2024

Fixes #82. @AY2324S2-CS2103T-W12-2/developers can someone help check whitespaces don't create unrecoverable states in the app.

@AdityaB4 AdityaB4 added this to the v1.4 milestone Apr 9, 2024
@AdityaB4 AdityaB4 requested a review from a team April 9, 2024 16:05
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (4767dbf) to head (4de54c3).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #126   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity      508      508           
=========================================
  Files            98       98           
  Lines          2003     2003           
  Branches        208      208           
=========================================
  Hits           1289     1289           
  Misses          630      630           
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blaukc
Copy link

blaukc commented Apr 10, 2024

Fixes #82. @AY2324S2-CS2103T-W12-2/developers can someone help check whitespaces don't create unrecoverable states in the app.

what does unrecoverable states mean & how are they created

@yadunut
Copy link

yadunut commented Apr 15, 2024

As of now, tag names only support alphanumeric characters, so underscore doesn't work

@AdityaB4
Copy link
Author

As of now, tag names only support alphanumeric characters, so underscore doesn't work

@yadunut would it be right to change this to just say whitespaces are not accepted then?

@yadunut
Copy link

yadunut commented Apr 15, 2024

I think if you change it to "You can use capitalization such as camelCasing" to distinguish different words in a tag and the no whitespaces part and then write a line in the glossary about camelCasing

@AdityaB4 AdityaB4 force-pushed the aditya/update-tag-docs branch from db88338 to 4de54c3 Compare April 15, 2024 10:56
@blaukc blaukc merged commit fd1e85a into master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Tag is unable to accept string with space inside
3 participants