Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for find_free_time #131

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

blaukc
Copy link

@blaukc blaukc commented Apr 10, 2024

Added validation for start time < end time check for find_free_time

Validation can be added as setting a start time greater than end time will NOT result in no students being shown, which is an incorrect result (bug).

Can be allowed only if the current behavior causes the software to misbehave (i.e., crash, give incorrect results, store inconsistent data, or make it unusable for typical users).

Closes: #107, #79

@blaukc blaukc added this to the v1.4 milestone Apr 10, 2024
@blaukc blaukc requested a review from a team April 10, 2024 05:29
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 54.54%. Comparing base (ce10f9d) to head (549784f).

Files Patch % Lines
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 6 Missing ⚠️
...ddress/logic/parser/FindFreeTimeCommandParser.java 0.00% 2 Missing ⚠️
...a/seedu/address/model/student/IsFreePredicate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #131      +/-   ##
============================================
- Coverage     54.76%   54.54%   -0.23%     
  Complexity      434      434              
============================================
  Files            98       98              
  Lines          1983     1991       +8     
  Branches        205      206       +1     
============================================
  Hits           1086     1086              
- Misses          861      869       +8     
  Partials         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@taufiq taufiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work!

@blaukc blaukc merged commit 4a6861d into master Apr 12, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] find_free_time end time can be earlier than start time
2 participants