Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Planned Enhancements appendix #144

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Add Planned Enhancements appendix #144

merged 3 commits into from
Apr 15, 2024

Conversation

AdityaB4
Copy link

Resolves #130.

@AdityaB4 AdityaB4 added the documentation Improvements or additions to documentation label Apr 15, 2024
@AdityaB4 AdityaB4 added this to the v1.4 milestone Apr 15, 2024
@AdityaB4 AdityaB4 requested a review from a team April 15, 2024 05:45
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (bd2418a) to head (dc8d6e3).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #144   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity      508      508           
=========================================
  Files            98       98           
  Lines          2003     2003           
  Branches        208      208           
=========================================
  Hits           1289     1289           
  Misses          630      630           
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@blaukc blaukc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment on lines +530 to +532
ModContacts currently supports input in English. This will be extended to more languages in future versions.

**Note**: Attempting to input text in another language may produce unpredicatble behaviour in the current version of the app, and is to be done at the user's risk.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also adding support for non-alpha numeric characters such as s/o in Indian names

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd missed that, thanks for catching this!

@AdityaB4 AdityaB4 requested review from yadunut and blaukc April 15, 2024 11:07
@blaukc blaukc merged commit 218754d into master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document view_x planned enhancements
3 participants