Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update previously missed json edit #146

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Update previously missed json edit #146

merged 2 commits into from
Apr 15, 2024

Conversation

AdityaB4
Copy link

@AY2324S2-CS2103T-W12-2/developers

Update your root level preferences.json to:

{
  "guiSettings" : {
    "windowWidth" : 740.0,
    "windowHeight" : 688.0,
    "windowCoordinates" : {
      "x" : 446,
      "y" : 127
    }
  },
  "addressBookFilePath" : "data/modcontacts.json"
}

@AdityaB4 AdityaB4 added this to the v1.4 milestone Apr 15, 2024
@AdityaB4 AdityaB4 requested a review from a team April 15, 2024 07:05
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (bd2418a) to head (9d6eb60).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage     64.35%   64.35%           
  Complexity      508      508           
=========================================
  Files            98       98           
  Lines          2003     2003           
  Branches        208      208           
=========================================
  Hits           1289     1289           
  Misses          630      630           
  Partials         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yadunut yadunut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadunut yadunut merged commit 46c0d8f into master Apr 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants