Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module data #32

Merged
merged 5 commits into from
Mar 16, 2024
Merged

Conversation

blaukc
Copy link

@blaukc blaukc commented Mar 14, 2024

Created a ModuleMap class which is just a wrapper for a map from module code -> Module object, which will be useful for checking if a module exists and linking students to modules.

Not sure about quite a few things in this PR, like the location of the json file and how to the DataLoadingException when we read the module_data file.

@blaukc blaukc added this to the v1.2 milestone Mar 14, 2024
@blaukc blaukc requested a review from a team March 14, 2024 20:20
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 75.10%. Comparing base (7c90816) to head (783638d).

Files Patch % Lines
...main/java/seedu/address/commons/util/JsonUtil.java 54.54% 4 Missing and 1 partial ⚠️
src/main/java/seedu/address/model/AddressBook.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     73.93%   75.10%   +1.17%     
- Complexity      419      430      +11     
============================================
  Files            75       76       +1     
  Lines          1362     1386      +24     
  Branches        126      128       +2     
============================================
+ Hits           1007     1041      +34     
+ Misses          325      314      -11     
- Partials         30       31       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@taufiq taufiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is stellar code 🔥 what can you not do @blaukc !

@blaukc blaukc merged commit 31eee46 into AY2324S2-CS2103T-W12-2:master Mar 16, 2024
2 of 3 checks passed
@yadunut yadunut mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants