Delete student module command #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40 +/- ##
============================================
- Coverage 69.56% 67.10% -2.46%
Complexity 433 433
============================================
Files 81 83 +2
Lines 1528 1584 +56
Branches 142 150 +8
============================================
Hits 1063 1063
- Misses 430 486 +56
Partials 35 35 ☔ View full report in Codecov by Sentry. |
yadunut
reviewed
Mar 23, 2024
Comment on lines
+119
to
+122
| * Adds a module to a student in the address book. | ||
| * | ||
| * @param m The module code to be added. | ||
| * @param s The student to whom the module is to be added. |
There was a problem hiding this comment.
The comments on this function are wrong
yadunut
reviewed
Mar 23, 2024
Comment on lines
+96
to
+98
| * Checks if module `m` is held within the student | ||
| * @param m Module to check | ||
| * @return true if module is taken by student |
yadunut
reviewed
Mar 23, 2024
Comment on lines
+87
to
+89
| * Checks if module `m` is held within the student | ||
| * @param m Module to check | ||
| * @return true if module is taken by student |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented delete_module command (delete_module i/INDEX m/MODULECODE)
Added some SLAP to add_module as well
Closes: #22