Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add models for module timing #52

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Conversation

blaukc
Copy link

@blaukc blaukc commented Mar 25, 2024

Added the module timing which has the day, start time and end time

@blaukc blaukc added this to the v1.3 milestone Mar 25, 2024
@blaukc blaukc requested a review from a team March 25, 2024 15:42
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 2.77778% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 65.67%. Comparing base (c981d98) to head (9ff156c).

❗ Current head 9ff156c differs from pull request most recent head 9330d00. Consider uploading reports for the commit 9330d00 to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/model/module/Day.java 0.00% 12 Missing ⚠️
...c/main/java/seedu/address/model/module/Timing.java 0.00% 12 Missing ⚠️
.../java/seedu/address/model/module/ModuleTiming.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
- Coverage     67.10%   65.67%   -1.43%     
  Complexity      433      433              
============================================
  Files            83       86       +3     
  Lines          1584     1620      +36     
  Branches        150      150              
============================================
+ Hits           1063     1064       +1     
- Misses          486      521      +35     
  Partials         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@taufiq taufiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmag

Copy link

@yadunut yadunut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdityaB4 AdityaB4 self-requested a review March 27, 2024 03:48
Copy link

@AdityaB4 AdityaB4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blaukc blaukc merged commit 1f4e3cc into master Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants