Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary function in ModuleMapStorage #57

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

yadunut
Copy link

@yadunut yadunut commented Mar 29, 2024

Removes the unnecessary getPath function from moduleMapStorage. This isn't used as the module mappings are embedded in the jar file in JSON form.

@yadunut yadunut requested a review from a team March 29, 2024 05:38
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 65.25%. Comparing base (b5af1f7) to head (effa88d).

Files Patch % Lines
...ain/java/seedu/address/storage/StorageManager.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     65.18%   65.25%   +0.07%     
  Complexity      434      434              
============================================
  Files            87       87              
  Lines          1660     1658       -2     
  Branches        154      154              
============================================
  Hits           1082     1082              
+ Misses          540      538       -2     
  Partials         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@taufiq taufiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@AdityaB4 AdityaB4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit below. Looks good beyond that.

Copy link

@blaukc blaukc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yadunut yadunut merged commit 0193e2a into AY2324S2-CS2103T-W12-2:master Apr 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants