Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation for moduleCode #60

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

blaukc
Copy link

@blaukc blaukc commented Apr 2, 2024

small pr

Closes: #39

@blaukc blaukc requested a review from a team April 2, 2024 15:11
@blaukc blaukc added this to the v1.3b milestone Apr 2, 2024
@blaukc blaukc changed the title Add validation for moduleCode feat: add validation for moduleCode Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 59.84%. Comparing base (e9ba2ff) to head (942ebef).

Files Patch % Lines
...in/java/seedu/address/logic/parser/ParserUtil.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
- Coverage     59.97%   59.84%   -0.14%     
  Complexity      434      434              
============================================
  Files            91       91              
  Lines          1809     1813       +4     
  Branches        175      176       +1     
============================================
  Hits           1085     1085              
- Misses          686      690       +4     
  Partials         38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@yadunut yadunut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blaukc blaukc merged commit a25acda into master Apr 2, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation for module code for add_module command (and delete_module)
2 participants