feat: Add find_free_time command
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This predicate checks that for a given time range, a student is free.
Adds a new command similar to `FindCommand` except it finds students who are free in the specified timing.
Wrong logic this just returned false for when a student is free at the specified timing.
A `FindFreeTimeCommandParser` to parse and crap out the `FindFreeTimeCommand` with the relevant `startTime` and `endTime` parsed
Whitespace separation was missing when stating how the `find_free_time` command is to be used.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
============================================
- Coverage 59.64% 57.86% -1.79%
Complexity 434 434
============================================
Files 91 94 +3
Lines 1819 1875 +56
Branches 178 186 +8
============================================
Hits 1085 1085
- Misses 696 752 +56
Partials 38 38 ☔ View full report in Codecov by Sentry. |
Adds a 'd/' prefix to the `FindFreeTimeCommand` so that users can specify a day.
blaukc
approved these changes
Apr 3, 2024
Comment on lines
32
to
41
| return student.getModuleTimings() | ||
| .stream() | ||
| .filter( | ||
| moduleTiming -> moduleTiming.getDay().equals(day) | ||
| ) | ||
| .noneMatch( | ||
| moduleTiming -> | ||
| startTime.compareTo(moduleTiming.getEndTime()) == -1 | ||
| && endTime.compareTo(moduleTiming.getStartTime()) == 1 | ||
| ); |
There was a problem hiding this comment.
Very cool use of streams! The compareTo part maybe should be < 0 instead of == -1 (viceversa for the ==1 part), according to Sam Patrick Floyd from StackOverflow
| /** | ||
| * Tests that a {@code Student} is free between a given timing | ||
| */ | ||
| public class IsFreePredicate implements Predicate<Student> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
find_free_timecommand that finds all students who do not have any module timings that clash with the specified timing.Solves #45
Example command
find_free_time d/Wed st/1845 et/1900