fix: Keep module state when editing students #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug (#61) pointed out by @blaukc where if we edit a student using the
edit
command and don't intend to change their modules, their module state gets completely wiped.When we parse the
EditCommand
we create anEditStudentDescriptor
instance which by default is initialized as a List with 0 entries.So when executing the command we use the
getModules
function to decide if we want to keep the old module state or replace it with new module state. The bug was that the logic for the forgetModules
always returns a non-nullOptional
value (because it checks ifmodules
is null which never happens bcos always initialised with empty list), thereby always taking the empty list of modules from theEditStudentDescriptor
instance and not the oldStudent
instance, thus wiping out the modules state.This commit initializes
modules
asnull
so thatgetModules
works as intended.