Add delete_timing
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaukc
approved these changes
Apr 4, 2024
Comment on lines
67
to
70
| // TODO: check if validation is needed | ||
| // if (model.doesStudentModuleTimingClash(studentToModify, moduleTiming)) { | ||
| // throw new CommandException(MESSAGE_MODULE_TIMING_CLASH); | ||
| // } |
There was a problem hiding this comment.
I believe this should be a validation to check if the module timing exists in the Student
Comment on lines
37
to
38
| public static final String MESSAGE_MODULE_TIMING_CLASH = | ||
| "There is a clash in module timings"; |
There was a problem hiding this comment.
This can be removed/changed to smth else
AdityaB4
force-pushed
the
add-delete-timing
branch
from
60e3e95 to
1213415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54.
Uses the same command format as
add_timing.