Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve defensiveness of Logic and Model components #280

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

yisiox
Copy link

@yisiox yisiox commented Apr 15, 2024

Adding assertions, logging and checking code quality.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (9b4d9e3) to head (41b6aab).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #280      +/-   ##
============================================
+ Coverage     77.02%   77.38%   +0.35%     
  Complexity      513      513              
============================================
  Files            74       74              
  Lines          1589     1605      +16     
  Branches        143      145       +2     
============================================
+ Hits           1224     1242      +18     
  Misses          335      335              
+ Partials         30       28       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aureliony aureliony added this to the v1.4 milestone Apr 15, 2024
@yisiox yisiox marked this pull request as ready for review April 15, 2024 14:38
@yisiox
Copy link
Author

yisiox commented Apr 15, 2024

Closes #154

Copy link

@aureliony aureliony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aureliony aureliony merged commit 9239205 into master Apr 15, 2024
8 checks passed
@aureliony aureliony linked an issue Apr 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify coding standard compliance
2 participants